[compiler] Detect snake_case_ref as a ref-like name#35137
Open
mdmower-csnw wants to merge 5 commits intofacebook:mainfrom
Open
[compiler] Detect snake_case_ref as a ref-like name#35137mdmower-csnw wants to merge 5 commits intofacebook:mainfrom
mdmower-csnw wants to merge 5 commits intofacebook:mainfrom
Conversation
Update ref-like name regex to detect `x_ref` as a ref, similar to `xRef`.
Author
josephsavona
requested changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update ref-like name regex to detect
x_refas a ref, similar toxRef.How did you test this change?
A test fixture has been added to verify that
custom_refis detected as a ref when used in auseCallbackhook.